ci: Add Slack notifications when releases and pre-releases are cut #9596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
reviewed
Oct 21, 2022
| @@ -8,7 +8,7 @@ on: | |||
| - "v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+" # e.g. v0.37.0-rc1, v0.38.0-rc10 | |||
|
|
|||
| jobs: | |||
| goreleaser: | |||
| prerelease: | |||
There was a problem hiding this comment.
Does this change imply we need to rename as well in lines 24 and 34 below? Or is it just a name collision?
There was a problem hiding this comment.
No, the change here just changes the job ID (like a variable name). The references to goreleaser on the other lines are important to keep as-is because they indicate the details of the GitHub action to execute.
sergio-mena
reviewed
Oct 21, 2022
| "type": "section", | ||
| "text": { | ||
| "type": "mrkdwn", | ||
| "text": ":sparkles: New Tendermint pre-release: <${{ env.RELEASE_URL }}|${{ github.ref_name }}>" |
There was a problem hiding this comment.
Can you also add :champagne:?
... just kidding 😄
There was a problem hiding this comment.
Actually that's a good idea, but it'd be better for the releases (instead of the pre-releases) 😁
sergio-mena
approved these changes
Oct 21, 2022
|
We should probably steal that :) |
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically notify the team when pre-releases and releases are cut.
Pre-release notification rendered
Release notification rendered
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed