Revert make proto-gen in #9590
#9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
reviewed
Oct 25, 2022
proto/tendermint/types/types.pb.go
Outdated
| // BlockIdFlag indicates which BlockID the signature is for | ||
| // BlockIdFlag indicates which BlcokID the signature is for |
There was a problem hiding this comment.
I have a feeling this is the one line change that's causing the generated code checker to fail which I think is fine. I think we just need to update the documentation on the .proto file.
cmwaters
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
make proto-genis changing the dependencies in the auto-generated code, which is causing problem in CI.This temporary fix reverts the
make proto-genintroduced by #9590This is temporary: we need to find out why
make proto-genis introducing those dependency changes.PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed