-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CLI): envd up a GPU image without GPUs #246
Labels
Comments
mean ignore cuda command? |
No, users build.envd may look like:
When the user run This feature is to launch a CPU container with the same build.envd when user run |
maybe like this? var CommandUp = &cli.Command{
+ &cli.BoolFlag{
+ Name: "no-gpu",
+ Usage: "launch same cpu container without gpu",
+ Value: false,
},
},
Action: up,
} gpu_enable := clicontext.Bool("no-gpu")
var gpu bool
if gpu_enable {
gpu = false
}else {
gpu = builder.GPUEnabled()
}
} |
LGTM. |
kenwoodjw
added a commit
to kenwoodjw/envd
that referenced
this issue
Jun 20, 2022
Signed-off-by: GitHub <noreply@github.com>
gaocegege
pushed a commit
that referenced
this issue
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Now we consider the user wants a GPU if
cuda
is called in build.envd. But we may need to supportenvd up --no-gpu
.The text was updated successfully, but these errors were encountered: