Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Fix sdist didn't include go files #1068

Merged
merged 11 commits into from
Oct 21, 2022
Merged

bug: Fix sdist didn't include go files #1068

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5601edf
fix
VoVAllen Oct 20, 2022
d0b83f9
lint
VoVAllen Oct 20, 2022
31a2110
lint2
VoVAllen Oct 20, 2022
4d32c1f
address comment
VoVAllen Oct 20, 2022
e6b4401
fix
VoVAllen Oct 20, 2022
77cdc32
fix
VoVAllen Oct 20, 2022
16ed770
fix
VoVAllen Oct 20, 2022
5f02ba1
fix
VoVAllen Oct 20, 2022
5190194
Merge remote-tracking branch 'tensorchord/main' into fix_sdist
VoVAllen Oct 20, 2022
75a7272
fix
VoVAllen Oct 20, 2022
f331094
fix
VoVAllen Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import distutils.command.sdist
import os
import shutil
from setuptools.command.sdist import sdist
from setuptools import setup, Extension, find_packages
from setuptools.command.build_ext import build_ext
import subprocess
Expand Down Expand Up @@ -57,7 +57,7 @@ def build_extension(self, ext: Extension) -> None:
shutil.copy("bin/envd", bin_path)


class SdistCommand(distutils.command.sdist.sdist):
class SdistCommand(sdist):
def run(self):
errno = subprocess.call(["make", "generate-git-tag-info"])
assert errno == 0, "Failed to generate git tag info"
Expand Down