Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prefix for cache id #204

Merged
merged 2 commits into from
May 27, 2022
Merged

feat: Add prefix for cache id #204

merged 2 commits into from
May 27, 2022

Conversation

gaocegege
Copy link
Member

Add cache prefix to avoid conflict.

Signed-off-by: Ce Gao cegao@tensorchord.ai

Signed-off-by: Ce Gao <cegao@tensorchord.ai>
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@VoVAllen
Copy link
Member

Does this mean each project will have its own cache, and it's not shared across project?

@gaocegege
Copy link
Member Author

Does this mean each project will have its own cache, and it's not shared across project?

I think so.

Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may want to provide shared cache among projects later if needed.

@gaocegege gaocegege merged commit e0984bb into main May 27, 2022
@gaocegege gaocegege deleted the cachekey branch May 27, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants