feat: Initial support for R language #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
terrytangyuan
commented
Jun 9, 2022
| @@ -60,6 +62,28 @@ func ruleFuncPyPIPackage(thread *starlark.Thread, _ *starlark.Builtin, | |||
| return starlark.None, nil | |||
| } | |||
|
|
|||
| func ruleFuncRPackage(thread *starlark.Thread, _ *starlark.Builtin, | |||
There was a problem hiding this comment.
Created a separate function instead of reusing ruleFuncPyPIPackage since we will need to extend it in the future for R specific installation.
12 tasks
gaocegege
approved these changes
Jun 10, 2022
| base = llb.Image("docker.io/gaocegege/python:3.8-ubuntu20.04") | ||
| if g.Language == "r" { | ||
| base = llb.Image("docker.io/r-base:4.2.0") | ||
| // r-base image already has GID 1000. |
There was a problem hiding this comment.
Maybe we can always use 1001. But here LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: terrytangyuan terrytangyuan@gmail.com