feat: Support SSH #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoVAllen
added
status/blocked 🚧
help wanted 🆘
VoVAllen
commented
Apr 22, 2022
cmd/midi/build.go
Outdated
| @@ -112,6 +112,10 @@ func actionBuild(clicontext *cli.Context) error { | |||
| }, | |||
| }, | |||
| }, | |||
| LocalDirs: map[string]string{ | |||
| // TODO: how to properly select build context? | |||
| "context": "/home/ubuntu/workspace/MIDI/", | |||
There was a problem hiding this comment.
How to properly specify context now?
There was a problem hiding this comment.
Maybe we could use the current dir as the build context?
gaocegege
approved these changes
Apr 22, 2022
cmd/midi/build.go
Outdated
| @@ -112,6 +112,10 @@ func actionBuild(clicontext *cli.Context) error { | |||
| }, | |||
| }, | |||
| }, | |||
| LocalDirs: map[string]string{ | |||
| // TODO: how to properly select build context? | |||
| "context": "/home/ubuntu/workspace/MIDI/", | |||
There was a problem hiding this comment.
Maybe we could use the current dir as the build context?
| func (g Graph) copyMidiSSHServer(root llb.State) llb.State { | ||
| run := root.File(llb.Mkdir("/var/midi/remote/", 0700, llb.WithParents(true))). | ||
| File(llb.Mkdir("/var/midi/bin/", 0700, llb.WithParents(true))). | ||
| File(llb.Copy(llb.Local("context"), "examples/ssh_keypairs/public.pub", "/var/midi/remote/authorized_keys")). |
There was a problem hiding this comment.
We can open an issue to keep track of this hard-coded key.
|
Please rebase the main branch |
VoVAllen
commented
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #16
Copy the midi-ssh into the container.
Found that the username used to ssh doesn't matter (i.e. ssh ubuntu@xxxx and ssh root@xxx both works)
TODO: