Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): Unify CLI style about env and image #550

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

VoVAllen
Copy link
Member

@VoVAllen VoVAllen commented Jul 5, 2022

Fix #513

Change:
envd get envs -> envd envs list
envd get envs deps -> envd envs describe

Same for image related commands

Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@VoVAllen
Copy link
Member Author

VoVAllen commented Jul 5, 2022

Related: #551

@VoVAllen VoVAllen changed the title feat(CLI): Unify CLI style about env and image feat(CLI): Unify CLI style about env and image WIP Jul 5, 2022
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@VoVAllen VoVAllen changed the title feat(CLI): Unify CLI style about env and image WIP feat(CLI): Unify CLI style about env and image Jul 5, 2022
@VoVAllen VoVAllen requested a review from gaocegege July 5, 2022 09:33
pkg/app/env.go Outdated Show resolved Hide resolved
pkg/app/image.go Outdated Show resolved Hide resolved
pkg/shell/zsh_test.go Show resolved Hide resolved
Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@VoVAllen VoVAllen requested a review from gaocegege July 5, 2022 12:28
@gaocegege
Copy link
Member

LGTM!

@gaocegege gaocegege merged commit f71cd7f into tensorchord:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat(CLI): Unify CLI style about env and image
2 participants