Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the for the new saving related issue for seq2seq #2839

Closed
wants to merge 1 commit into from

Conversation

qlzh727
Copy link
Member

@qlzh727 qlzh727 commented Jul 7, 2023

Description

Brief Description of the PR:

Fixes # (issue)

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@boring-cyborg boring-cyborg bot added the seq2seq label Jul 7, 2023
@qlzh727 qlzh727 mentioned this pull request Jul 7, 2023
3 tasks
@@ -130,6 +130,7 @@ def test_save_load_layer(attention_cls):
model.compile("rmsprop", "mse")
y_ref = model.predict_on_batch([x_test, dummy_data.query, dummy_data.state])

model.use_legacy_config = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't do this maybe thats it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants