Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py execution depends on current working directory #85

Closed
SinaChavoshi opened this issue Jul 22, 2020 · 0 comments · Fixed by #190
Closed

setup.py execution depends on current working directory #85

SinaChavoshi opened this issue Jul 22, 2020 · 0 comments · Fixed by #190
Labels
enhancement New feature or request

Comments

@SinaChavoshi
Copy link
Collaborator

This is a small issue that impacts users if they build the package from any folder other than python. For example if users runs the build package command as

python python/setup.py bdist_wheel

The build will complete with an empty package, source will not include any of the modules.
to mitigate this issue setup.py should set current working directory to setup.py location.

import os
setup_file_directory = os.path.dirname(os.path.abspath(__file__)
os.chdir(setup_file_directory)
@pavithrasv pavithrasv added the enhancement New feature or request label Aug 18, 2020
copybara-service bot pushed a commit that referenced this issue Sep 24, 2020
copybara-service bot pushed a commit that referenced this issue Sep 24, 2020
copybara-service bot pushed a commit that referenced this issue Sep 24, 2020
copybara-service bot pushed a commit that referenced this issue Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants