RFC: TensorFlow Lattice 2.0 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmilanifard
requested review from
brijk7,
ewilderj,
martinwicke and
theadactyl
as code owners
This was referenced Dec 7, 2019
|
@mmilanifard TFL v2.0 looks very good, and I am very excited about TFMA integrations. One minor note on the code structure. Have you considered to use tfl.layers.Linear, tfl.layers.PwlCalibrated etc instead of tfl.linear_layers.Linear, tfl.pwl_calibration_layer.PwlCalibratedLayer? The current structure is hard to memorize. |
|
@mmilanifard Could you post the design review notes? If this was accepted, please update this PR with the results and I'll get this merged. |
TF Lattice is launched at https://www.tensorflow.org/lattice.
|
Design was reviewed and accepted in Jan. Updated the RFC with the changes. Should be ready to merge. |
|
Launched at https://www.tensorflow.org/lattice |
ematejska
approved these changes
Apr 15, 2020
ematejska
added
RFC: Accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment period is open till Jan 3, 2020.
TensorFlow Lattice 2.0
Objective
TensorFlow Lattice (TFL) is an implementation of
Deep Lattice Networks in TensorFlow. Using TFL, one can create models with guaranteed shape constraints such as monotonicity with respect to a set of features. TFL was open sourced in 2017 (https://github.com/tensorflow/lattice) and was based on TF 1.x.
This RFC covers the goals and design details of TFL 2.0 with TF 2.x eager support, Keras layers and canned estimators.