Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TF 2.0 #31

Closed
lc0 opened this issue Jan 31, 2019 · 3 comments
Closed

Support TF 2.0 #31

lc0 opened this issue Jan 31, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@lc0
Copy link
Contributor

lc0 commented Jan 31, 2019

Any plans to support TensorFlow 2? Since Datasets are not released and hopefully TF2 is going to be released in the next months, would totally make sense.

What do you think?

Currently I've got the issues with contrib part

# Flatten
--> 127   flat_ds = tf.contrib.framework.nest.flatten(nested_ds)
    128   flat_np = []
@lc0 lc0 added the enhancement New feature or request label Jan 31, 2019
@rsepassi rsepassi changed the title Any plans to support TF2? Support TF2 Feb 1, 2019
@rsepassi rsepassi changed the title Support TF2 Support TF 2.0 Feb 1, 2019
@rsepassi
Copy link
Contributor

rsepassi commented Feb 1, 2019

Absolutely! We're aiming to support the TF 2.0 preview shortly.

@rsepassi rsepassi mentioned this issue Feb 1, 2019
Closed
@rsepassi
Copy link
Contributor

rsepassi commented Feb 1, 2019

Linked issue: tensorflow/tensorflow#25367

tfds-copybara pushed a commit that referenced this issue Feb 1, 2019
Start Travis testing against TF 2.0 (#31)
740e722 
PiperOrigin-RevId: 232046753
@dynamicwebpaige dynamicwebpaige mentioned this issue Feb 4, 2019
Closed
@rsepassi
Copy link
Contributor

rsepassi commented Feb 4, 2019

TFDS is now 2.0-ready. We’re testing against 2.0 in Travis.

One exception for now is that the LSUN dataset cannot be generated with TF 2.0 because of the use of tf.contrib. We have a plan to resolve it. See #34.

@rsepassi rsepassi closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lc0 @rsepassi