Skip to content

Commit 2b23afd

Browse files
G4Gcopybara-github
authored andcommitted
Corrects an error in dual_quaternion.point_to_dual_quaternion.
PiperOrigin-RevId: 413506277
1 parent 38771b1 commit 2b23afd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tensorflow_graphics/geometry/transformation/dual_quaternion.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,8 +454,8 @@ def point_to_dual_quaternion(
454454

455455
return tf.concat(
456456
(ones_vector,
457-
tf.zeros_like(point),
458-
ones_vector,
457+
tf.zeros(tf.concat((tf.shape(point)[0:-1], [4]), -1),
458+
dtype=point.dtype),
459459
point), -1)
460460

461461

tensorflow_graphics/geometry/transformation/tests/dual_quaternion_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,11 +388,11 @@ def test_point_to_dual_quaternion_preset(self):
388388
dual_quaternions = dual_quaternion.point_to_dual_quaternion(points)
389389

390390
ones_vector = tf.ones_like(points)[..., 0]
391-
zeros_vector = tf.zeros_like(points)
391+
zeros_vector = tf.zeros(tf.concat((tf.shape(points)[0:-1], [4]), -1),
392+
dtype=points.dtype)
392393

393394
self.assertAllEqual(dual_quaternions[..., 0], ones_vector)
394-
self.assertAllEqual(dual_quaternions[..., 1:4], zeros_vector)
395-
self.assertAllEqual(dual_quaternions[..., 4], ones_vector)
395+
self.assertAllEqual(dual_quaternions[..., 1:5], zeros_vector)
396396
self.assertAllEqual(dual_quaternions[..., 5:8], points)
397397

398398

0 commit comments

Comments
 (0)