Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial HDFS tests #1225

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Add initial HDFS tests #1225

merged 3 commits into from
Dec 12, 2020

Conversation

yongtang
Copy link
Member

This PR adds initial HDFS tests. The HDFS server is setup with sequenceiq/hadoop-docker:2.7.0 to start with.

This is part of #1183.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@vnghia
Copy link
Contributor

vnghia commented Dec 12, 2020

Hi @yongtang

I have some questions:

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

@vnvo2409

Should we merge the tests here after #1221 is done

I think we can merge this PR first for now. This PR setup the Hadoop with docker image sequenceiq/hadoop-docker:2.7.0. Though the test that has been added in this PR is really bare-bone. It just shows that Hadoop setup is working. The added test can be easily migrated to the parameterized pytest you have been doing after #1221 is done.

Regarding GCS test, I am thinking of copying the emulator from google-cloud-cpp to this repository. Or I could create a Docker image for it.

I think copying the emulator from google-cloud-cpp is good enough 👍

@vnghia
Copy link
Contributor

vnghia commented Dec 12, 2020

I think we can merge this PR first for now

Ah sorry, I mean merge the tests in this PR to #1221 😄

Copy link
Member

@kvignesh1420 kvignesh1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yongtang yongtang merged commit 9b5e233 into tensorflow:master Dec 12, 2020
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
* Add initial HDFS tests

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Install Java and libhdfs.so for tests

* Fix kokorun

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang yongtang deleted the hdfs-tests branch May 17, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants