This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
First step to getting Minigo running on Windows #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amj
approved these changes
Nov 28, 2018
| #include "absl/strings/str_cat.h" | ||
|
|
||
| namespace minigo { | ||
| namespace file { | ||
|
|
||
| #ifdef _WIN32 |
There was a problem hiding this comment.
Not yet. It's wrapped up with the rest of the absl::File API, which is on the road map to release but not for quite some time.
| @@ -24,7 +24,7 @@ namespace minigo { | |||
|
|
|||
| constexpr uint16_t Coord::kPass; | |||
| constexpr uint16_t Coord::kInvalid; | |||
| constexpr char Coord::kKgsColumns[]; | |||
| const char Coord::kKgsColumns[20] = "ABCDEFGHJKLMNOPQRST"; | |||
There was a problem hiding this comment.
i'm scared to ask why you needed to do this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets Minigo building and its tests passing on Windows. This PR doesn't make any attempt to get any inference engine working (other than FakeDualNet), so the windows code currently only builds with
--define=tf=0.Most of the work here was file system yak shaving.