Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neural GPU] Running in Python 3.5 #1251

Closed
arsenious opened this issue Mar 24, 2017 · 11 comments
Closed

[Neural GPU] Running in Python 3.5 #1251

arsenious opened this issue Mar 24, 2017 · 11 comments
Assignees

Comments

@arsenious
Copy link

arsenious commented Mar 24, 2017

Thank you for the code
I tried running the code in Python 3.5 (after converting the code using 2to3) , Tensorflow 1.01 but it ran into a couple of issues. Some fixes:

  1. In wmt_utils.py, change line 44 to ensure everything inside re.compile is of type byte
    _WORD_SPLIT = re.compile( b"([" + _PUNCTUATION.encode() + b"])" )

  2. In data_utils.py , change line 113 to keep k as an int
    k = (l-1)//2

I've just tested the bmul task and it seems to be running properly. I'll update as and when I find more issues.

@aselle
Copy link
Contributor

aselle commented Mar 24, 2017

It would be great if you could package this into a pull-request. Thanks!

@aselle aselle added type:bug Bug in the code stat:awaiting response Waiting on input from the contributor labels Mar 24, 2017
@arsenious
Copy link
Author

arsenious commented Mar 31, 2017

Hi aselle
To be honest, I'm relatively new to tensorflow as well as to git. I have used 2to3 to change all the scripts automatically. Wouldn't merging these changes to the repo cause issues for people using Python 2.7 ?

Thanks

@aselle aselle removed the stat:awaiting response Waiting on input from the contributor label Mar 31, 2017
@arsenious
Copy link
Author

@aselle

Hi

I have made a pull request. Most of the changes were done by the python 2to3 script. However, changes to division operations performed on array indices had to be changed manually. ( / to // to ensure that the result was an integer). Please let me know what further actions I should take. I also signed the CLA.

Thanks

@aselle
Copy link
Contributor

aselle commented Mar 31, 2017

Awesome! Could you link to the pull request here? Or link the pull request to hear by Using "Fixes #1251" in the last commit of your git branch that you included in the pr. Thanks.

@arsenious
Copy link
Author

Here is the link to the pull request. #1281

@karmel
Copy link
Contributor

karmel commented Feb 22, 2018

@lukaszkaiser Can you comment on this or close if no longer relevant?

@karmel karmel added stat:awaiting maintainer Waiting on input from the maintainer and removed type:bug Bug in the code labels Feb 22, 2018
@lukaszkaiser
Copy link
Contributor

I think it's still a bug, just nobody corrected it (and the above PR didn't get merged).

@karmel karmel removed the stat:awaiting maintainer Waiting on input from the maintainer label Feb 23, 2018
@karmel
Copy link
Contributor

karmel commented Feb 24, 2018

@cclauss Note that this is an open issue on Python3 compatibility with a code owner available, if you want to contribute.

@jvishnuvardhan
Copy link
Contributor

@lukaszkaiser Is this still an issue or was it solved by the PR? Thanks!

@lukaszkaiser
Copy link
Contributor

From what I see the PR never got merged, so I don't think the problem is solved. But it may not be that relevant any more?

@tensorflowbutler
Copy link
Member

Hi There,
We are checking to see if you still need help on this, as this seems to be considerably old issue. Please update this issue with the latest information, code snippet to reproduce your issue and error you are seeing.
If we don't hear from you in the next 7 days, this issue will be closed automatically. If you don't need help on this issue any more, please consider closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants