-
Notifications
You must be signed in to change notification settings - Fork 45.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neural GPU] Running in Python 3.5 #1251
Comments
It would be great if you could package this into a pull-request. Thanks! |
Hi aselle Thanks |
Hi I have made a pull request. Most of the changes were done by the python 2to3 script. However, changes to division operations performed on array indices had to be changed manually. ( / to // to ensure that the result was an integer). Please let me know what further actions I should take. I also signed the CLA. Thanks |
Awesome! Could you link to the pull request here? Or link the pull request to hear by Using "Fixes #1251" in the last commit of your git branch that you included in the pr. Thanks. |
Here is the link to the pull request. #1281 |
@lukaszkaiser Can you comment on this or close if no longer relevant? |
I think it's still a bug, just nobody corrected it (and the above PR didn't get merged). |
@cclauss Note that this is an open issue on Python3 compatibility with a code owner available, if you want to contribute. |
@lukaszkaiser Is this still an issue or was it solved by the PR? Thanks! |
From what I see the PR never got merged, so I don't think the problem is solved. But it may not be that relevant any more? |
Hi There, |
Thank you for the code
I tried running the code in Python 3.5 (after converting the code using 2to3) , Tensorflow 1.01 but it ran into a couple of issues. Some fixes:
In wmt_utils.py, change line 44 to ensure everything inside re.compile is of type byte
_WORD_SPLIT = re.compile( b"([" + _PUNCTUATION.encode() + b"])" )
In data_utils.py , change line 113 to keep k as an int
k = (l-1)//2
I've just tested the bmul task and it seems to be running properly. I'll update as and when I find more issues.
The text was updated successfully, but these errors were encountered: