[Fix]change 'KEYS' command in GetKeyBucketsAndOptimizerParamsWithName function to 'SCAN' command #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFHeka
force-pushed
the
redis-dev
branch
3 times, most recently
from
2341ab9
to
e622d0c
Compare
…tion to 'SCAN' command. lock file when read or write json file in python codes. fix default value bug and the FindWithExists function is complete. Add the ability to set hashtags via Redis cluster servers slots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Command "KEYS" was used in the GetKeyBucketsAndOptimizerParamsWithName function by DE redis backend. But Command "KEYS" may cause lots of trouble, such as a serious service delay. Command "SCAN" should be a better choice. In fact, "KEYS" are banned in many companies' Redis services.
Fixes #179
What's more, add the ability to set hashtags via Redis cluster servers slots.
Type of change
Checklist:
How Has This Been Tested?
run it again.