Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add storage_slice_import parameter for easy rehashing table. #197

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Dec 20, 2021

Description

Add storage_slice_import parameter for easy rehashing table.

Also sorting cluster_slots after get it.

Also allow not to set expire to buckets

Fix many bug when rehash(rebuckets), but there are still lots of bugs.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

set storage_slice_import in redis backend config file.

@MoFHeka MoFHeka requested a review from rhdong as a code owner December 20, 2021 13:55
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you ran the Test Case manually?

Also sorting cluster_slots after get it.

Also allow not to set expire to buckets

Fix many bug when rehash(rebuckets), but there are still lots of bugs.
@rhdong
Copy link
Member

rhdong commented Dec 22, 2021

LGTM

@rhdong rhdong merged commit 35c5b03 into tensorflow:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants