Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Compatible with compiling problem with TensorFlow version 2.4 and 2.8. #276

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Sep 21, 2022

Description

[fix] Compatible with tensorflow::int64 is "long long" instead of "in…t64_t" when TensorFlow version is 2.4 or below.

[fix] Compatible with "tensorflow/core/platform/errors.h" but not "tensorflow/core/platform/error.h" when tensorflow version is greater than 2.8.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Compile TFRA with TensorFlow version 2.4 and 2.8.

…t64_t" when TensorFlow version is 2.4 or below.

[fix] Compatible with "tensorflow/core/platform/errors.h" but not "tensorflow/core/platform/error.h" when tensorflow version is greater than 2.8.
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 46e3dc2 into tensorflow:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants