Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Compatible with Tensorflow later than version 2.11.0. #331

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Jun 7, 2023

Description

Brief Description of the PR:

Compatibility update. Now TFRA is compatible with Tensorflow later than version 2.11.0 and pass all CI test in the NCG container tensorflow:23.04-tf2-py3.
It also supports automatic detection of TF compile cxx standard versions.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Run all test script under TF 2.11+

…is installed but running pkg_resources.get_distribution("tensorflow-recommenders-addons") will lead to the error with invalid version 'nsorflow-recommenders-addons-gpu'.
It also supports automatic detection of TF compile cxx standard versions.
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit e84368d into tensorflow:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants