[build] Disable EV build #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poinwater
force-pushed
the
disable-ev
branch
from
26314f0
to
03567d5
Compare
rhdong
reviewed
Sep 3, 2023
tensorflow_recommenders_addons/embedding_variable/python/ops/embedding_variable_ops_test.py
Outdated
Show resolved
Hide resolved
poinwater
force-pushed
the
disable-ev
branch
2 times, most recently
from
9703712
to
0728def
Compare
poinwater
force-pushed
the
disable-ev
branch
from
0728def
to
de73882
Compare
|
Hello @poinwater, the CI failure is caused by disk no space. Your code is perfect, and I can help merge it if no more modify from you. Thank you! |
|
@rhdong , I don't need to make any changes. Please merge my code, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabled Embedding Variables build in bazel build file due to the
ptr_util.hheader is removed from Tensorflow 2.13.The EV is not in used, so it's safe to remove it.
Related file used
ptr_utl.h: ev_op_helpers.hRelated commit: 960d53e
Brief Description of the PR: Disable EV build
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*