Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Support TF CheckpointManager in 2.9. And support create Checkpoint with custom model key. #373

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[Fix] Support TF CheckpointManager in 2.9. And support create Checkpoint with custom model key. #373

merged 1 commit into from
Nov 29, 2023

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Nov 29, 2023

Description

User may create Checkpoint class by passing keys "model", "optimizer" and so on. So root parameter in init function may be None. We need to walk through all kwargs.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Successfully run

horovodrun -np 2 python tensorflow_recommenders_addons/dynamic_embedding/python/kernel_tests/horovod_sync_train_test.py

@MoFHeka
[fix] Support TF CheckpointManager in 2.9.
f902eea 
User may create Checkpoint by passing keys "model", "optimizer" and so on. So root parameter in __init__ function may be None. We need to walk through all kwargs.
@MoFHeka MoFHeka requested a review from rhdong as a code owner November 29, 2023 13:48
rhdong
rhdong approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 754e2e8 into tensorflow:master Nov 29, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoFHeka @rhdong