Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]Switch tf version to 2.15.0 #388

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[CI]Switch tf version to 2.15.0 #388

merged 1 commit into from
Mar 22, 2024

Conversation

jq
Copy link
Collaborator

@jq jq commented Mar 11, 2024

Description

Brief Description of the PR:
enable the CI for TF2.15.x
Co-authored-by: rhdong rhdong2017@gmail.com
Co-authored-by: poinwater bcghost123@gmail.com

Type of change

  • upgrade dependency

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

Copy link

google-cla bot commented Mar 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jq jq force-pushed the master branch 7 times, most recently from e752173 to dde72bb Compare March 12, 2024 19:55
@rhdong rhdong requested review from rhdong and MoFHeka March 12, 2024 20:06
@jq jq force-pushed the master branch 14 times, most recently from ec11220 to eec1ef0 Compare March 18, 2024 19:27
@rhdong
Copy link
Member

rhdong commented Mar 22, 2024

Hi @jq , the CI issues have been resolved(all of the required docker images for that PR have been uploaded.), and pls pick the top commit link and continue your work. Thanks!

README.md Outdated
@@ -154,7 +156,7 @@ Please install a TensorFlow on your compiling machine, The compiler needs to kno
its headers according to the installed TensorFlow.

```sh
export TF_VERSION="2.8.3" # "2.6.3" are well tested.
export TF_VERSION="2.15.1" # "2.8.3" are well tested.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.8.3->2.11.0

README.md Outdated
@@ -275,6 +277,7 @@ sess_config.gpu_options.allow_growth = True
#### Compatibility Matrix
| TFRA | TensorFlow | Serving branch | Compiler | CUDA | CUDNN | Compute Capability |
|:------|:-----------|:---------------|:---------| :------------ | :---- | :------------ |
| 0.6.1 | 2.15.1 | r2.8 | GCC 7.3.1 | 11.2| 8.1 | 6.0, 6.1, 7.0, 7.5, 8.0, 8.6 |
Copy link
Member

@rhdong rhdong Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table can only be changed when publishing a new release.

pytest.txt Outdated
@@ -0,0 +1,7 @@
pytest~=6.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this file. Pls use the file with same name under the tools/install_deps

"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.11(for tensorflow 2.15.1)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "Programming Language :: Python :: 3.11",

README.md Outdated
@@ -107,6 +107,8 @@ is compiled differently. A typical example of this would be `conda`-installed Te

| TFRA | TensorFlow | Compiler | CUDA | CUDNN | Compute Capability | CPU |
|:------|:-----------|:-----------|:-----|:------|:-----------------------------|:--------------|
| 0.6.1 | 2.15.1 | GCC 7.3.1 | 11.2 | 8.1 | 6.0, 6.1, 7.0, 7.5, 8.0, 8.6 | x86 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change when releasing

README.md Outdated
@@ -171,7 +173,7 @@ pip install artifacts/tensorflow_recommenders_addons-*.whl
#### GPU Support
Only `TF_NEED_CUDA=1` is required and other environment variables are optional:
```sh
export TF_VERSION="2.8.3" # "2.6.3" is well tested.
export TF_VERSION="2.15.1" # "2.8.3" is well tested.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.11.0

@jq jq force-pushed the master branch 4 times, most recently from cf0d161 to 5e730fd Compare March 22, 2024 16:05
update the CI docker images for TF2.15.x
Co-authored-by: rhdong <rhdong2017@gmail.com>
Co-authored-by: poinwater <bcghost123@gmail.com>
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong changed the title switch tf version to 2.15.0 [CI ]switch tf version to 2.15.0 Mar 22, 2024
@rhdong rhdong changed the title [CI ]switch tf version to 2.15.0 [CI]Switch tf version to 2.15.0 Mar 22, 2024
@rhdong rhdong merged commit ba467f4 into tensorflow:master Mar 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants