Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Compatible with TF2.15 register_checkpoint_saver when multiple TFRA Embedding in one trackables. #403

Merged
merged 1 commit into from
May 6, 2024

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Apr 29, 2024

Description

In my previous tests, there was only one TFRA Embedding object passed into the trackables in the save loading function, even though there were multiple TFRA Embedding objects in the model.
However, we have tested that under certain composition conditions, the trackables may contain multiple TFRA Embedding, so the group of multiple loading functions should be returned.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Run the test.

@MoFHeka MoFHeka requested a review from rhdong as a code owner April 29, 2024 10:01
@MoFHeka MoFHeka changed the title [fix] Compatible with TF2.15 register_checkpoint_saver when multiple TFRA Embedding in one trackables. [Fix] Compatible with TF2.15 register_checkpoint_saver when multiple TFRA Embedding in one trackables. Apr 29, 2024
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 21c6235 into tensorflow:master May 6, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants