[FIX] raggedtensor should pass name in the eager mode #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
reviewed
Jun 5, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/ragged_embedding_ops.py
Show resolved
Hide resolved
jq
commented
Jun 5, 2024
| @@ -649,7 +649,7 @@ def _create_or_get_trainable(trainable_name): | |||
|
|
|||
| with ops.colocate_with(ids, ignore_existing=True): | |||
| if distribute_ctx.has_strategy(): | |||
| trainable_ = _distribute_trainable_store.get(name, None) | |||
| trainable_ = params._distribute_trainable_store.get(name, None) | |||
There was a problem hiding this comment.
@MoFHeka are we missing some unit test here?
jq
force-pushed
the
ragged_fix
branch
3 times, most recently
from
948a2b0
to
28a11bd
Compare
rhdong
reviewed
Jun 5, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_ops.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*