Replace TensorFlow image loading with stb_image #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think this is a good pragmatic way to get away from raw ops |
BradLarson
changed the title
compnerd
reviewed
Apr 6, 2020
…entationOnly, update with Saleem's suggestions.
compnerd
reviewed
Apr 6, 2020
|
Looks good. |
saeta
approved these changes
Apr 16, 2020
| import TensorFlow | ||
|
|
||
| final class ImageTests: XCTestCase { | ||
| let resourceBaseLocation = URL(fileURLWithPath: #file).deletingLastPathComponent() |
There was a problem hiding this comment.
will #file break in the forthcoming changes to not be full paths?
There was a problem hiding this comment.
That's a good point, it probably will. It looks like we have access to #filePath in our toolchain (I wasn't sure if we did), so I'll switch this and our other uses of #file to #filePath in anticipation.
There was a problem hiding this comment.
PR #449 is my quick fix to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our efforts to reduce our dependencies on TensorFlow libraries, this replaces the image saving and loading routines with ones provided by the stb_image C single headers. This is inspired by t-ae's cross-platform image loading library Swim. We're evaluating various image processing options, so this isn't guaranteed to be a permanent implementation, but it works well for our use cases right now.
The interface to the Image type has intentionally been left the same as it was before, in order to restrict all code changes to just Image.swift. I'll follow on with some modifications to the API in a later PR.
This is the last change needed to close out issue #225.