Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps google-auth-oauthlib dependency restriction to support up to version 1.0 #6246

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

arcra
Copy link
Member

@arcra arcra commented Mar 17, 2023

  • Motivation for features / changes
    As requested and noted in Loosen google-auth-oauthlib #6197, we can bump this restriction, which is currently affecting compatibility of TB with dependency requirements from other packages. After the OOB auth flow migration, this should be possible.

  • Technical description of changes
    Just bump the restriction for google-auth-oauthlib in our requirements.txt file, to support newer versions.

  • Detailed steps to verify changes work correctly (as executed by you)
    Executed the auth flows (both the console-only one, and the one that uses a browser in the same machine), and validated that they work as before with the newer version.

@arcra arcra requested a review from groszewn March 17, 2023 00:47
Copy link
Contributor

@groszewn groszewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arcra arcra merged commit a30f5dc into tensorflow:master Mar 17, 2023
@arcra arcra deleted the google-auth-version-bump branch March 17, 2023 20:18
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
…rsion 1.0 (tensorflow#6246)

* Motivation for features / changes
As requested and noted in tensorflow#6197, we can bump this restriction, which is
currently affecting compatibility of TB with dependency requirements
from other packages. After the OOB auth flow migration, this should be
possible.

* Technical description of changes
Just bump the restriction for `google-auth-oauthlib` in our
`requirements.txt` file, to support newer versions.

* Detailed steps to verify changes work correctly (as executed by you)
Executed the auth flows (both the console-only one, and the one that
uses a browser in the same machine), and validated that they work as
before with the newer version.
arcra added a commit to arcra/tensorboard that referenced this pull request Mar 31, 2023
…rsion 1.0 (tensorflow#6246)

* Motivation for features / changes
As requested and noted in tensorflow#6197, we can bump this restriction, which is
currently affecting compatibility of TB with dependency requirements
from other packages. After the OOB auth flow migration, this should be
possible.

* Technical description of changes
Just bump the restriction for `google-auth-oauthlib` in our
`requirements.txt` file, to support newer versions.

* Detailed steps to verify changes work correctly (as executed by you)
Executed the auth flows (both the console-only one, and the one that
uses a browser in the same machine), and validated that they work as
before with the newer version.
@arcra arcra mentioned this pull request Mar 31, 2023
arcra added a commit to arcra/tensorboard that referenced this pull request Mar 31, 2023
…rsion 1.0 (tensorflow#6246)

* Motivation for features / changes
As requested and noted in tensorflow#6197, we can bump this restriction, which is
currently affecting compatibility of TB with dependency requirements
from other packages. After the OOB auth flow migration, this should be
possible.

* Technical description of changes
Just bump the restriction for `google-auth-oauthlib` in our
`requirements.txt` file, to support newer versions.

* Detailed steps to verify changes work correctly (as executed by you)
Executed the auth flows (both the console-only one, and the one that
uses a browser in the same machine), and validated that they work as
before with the newer version.
arcra added a commit that referenced this pull request Mar 31, 2023
…rsion 1.0 (#6246)

* Motivation for features / changes
As requested and noted in #6197, we can bump this restriction, which is
currently affecting compatibility of TB with dependency requirements
from other packages. After the OOB auth flow migration, this should be
possible.

* Technical description of changes
Just bump the restriction for `google-auth-oauthlib` in our
`requirements.txt` file, to support newer versions.

* Detailed steps to verify changes work correctly (as executed by you)
Executed the auth flows (both the console-only one, and the one that
uses a browser in the same machine), and validated that they work as
before with the newer version.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
…rsion 1.0 (tensorflow#6246)

* Motivation for features / changes
As requested and noted in tensorflow#6197, we can bump this restriction, which is
currently affecting compatibility of TB with dependency requirements
from other packages. After the OOB auth flow migration, this should be
possible.

* Technical description of changes
Just bump the restriction for `google-auth-oauthlib` in our
`requirements.txt` file, to support newer versions.

* Detailed steps to verify changes work correctly (as executed by you)
Executed the auth flows (both the console-only one, and the one that
uses a browser in the same machine), and validated that they work as
before with the newer version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants