Added model file - CallmeMehdi #66

CallmeMehdi · 2021-07-26T13:40:20Z

Any pull request you open is subject to the TensorFlow Hub Terms of Service at www.tfhub.dev/terms and Google's Privacy Policy at https://www.google.com/policies/privacy.

google-cla · 2021-07-26T13:40:24Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

MorganR

Thanks for the PR Mehdi! Also please make sure to follow Google Bot's instructions and sign the CLA

assets/docs/CallmeMehdi/models/AraBERT/1.md

assets/docs/CallmeMehdi/CallmeMehdi.md

…owercase name

google-cla · 2021-07-27T23:33:06Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

CallmeMehdi · 2021-07-27T23:40:21Z

@googlebot I signed it!

CallmeMehdi · 2021-07-27T23:41:47Z

Thanks for the PR Mehdi! Also please make sure to follow Google Bot's instructions and sign the CLA

@MorganR , I have done the changes you asked me to, and signed the CLA.

WGierke · 2021-07-28T11:29:45Z

Hi @CallmeMehdi
Please provide the SavedModel in the tar.gz without any top-level directory like described here:

saved_model.tar.gz
├── assets/            # Optional.
├── assets.extra/      # Optional.
├── variables/
│     ├── variables.data-?????-of-?????
│     └──  variables.index
├── saved_model.pb
├── keras_metadata.pb  # Optional, only required for Keras models.
└── tfhub_module.pb    # Optional, only required for TF1 models.

The model files are currently containing within an arabert/ directory, which causes the validator to fail.

CallmeMehdi · 2021-07-28T11:49:38Z

Thank you for the insight @WGierke , it looks like that was the problem.

Also, @MorganR, are there any other changes you are requesting me to do?

assets/docs/callmemehdi/models/AraBERT/1.md

MorganR · 2021-07-28T12:33:28Z

assets/docs/callmemehdi/models/AraBERT/1.md

+
+## License
+
+[SOFTWARE LICENSE AGREEMENT - AraBERT](https://github.com/snakers4/silero-models/blob/master/LICENSE)


Shouldn't this be https://github.com/aub-mind/arabert/blob/master/arabert/LICENSE ?

Yes, absolutely, I think I didn't save when I changed it. Changing it right now.

assets/docs/callmemehdi/models/AraBERT/1.md

CallmeMehdi · 2021-07-30T01:37:35Z

@MorganR I have added the changes you requested, can you please check them for me. Thank you.

MorganR

Looking much better! Nearly there

MorganR · 2021-07-30T11:19:22Z

assets/docs/callmemehdi/models/AraBERT/1.md

@@ -1,6 +1,6 @@
 # Module callmemehdi/arabert/1

-AraBERT is an Arabic pretrained lanaguage model based on Google's BERT architechture.
+AraBERT is an Arabic pretrained lanaguage model based on Google's BERT base architechture.


nit: architecture

I'm sorry Morgan I didn't get this remark.

Just a small typo in architecture. You have an extra h part way through the word.

assets/docs/callmemehdi/models/AraBERT/1.md

MorganR · 2021-07-30T11:24:55Z

assets/docs/callmemehdi/models/AraBERT/1.md

@@ -1,6 +1,6 @@
 # Module callmemehdi/arabert/1


Please update the 'arabert' casing here or in the folder name so that they match

MorganR · 2021-07-30T11:25:44Z

assets/docs/callmemehdi/models/AraBERT/1.md

+
+```
+
+We need to take the last hidden state with ``` outputs[0] ``` which has the following shape:


It might be helpful to describe the outputs more. What else does the model output?

…n usage

CallmeMehdi · 2021-07-30T18:13:46Z

@MorganR, I've added the recent modification requests in the last commit, make sure to tell me if there are any notes or questions about it

MorganR

Just a few more small changes.

MorganR · 2021-08-05T19:20:32Z

assets/docs/callmemehdi/models/AraBERT/1.md

@@ -1,6 +1,6 @@
 # Module callmemehdi/arabert/1

-AraBERT is an Arabic pretrained lanaguage model based on Google's BERT architechture.
+AraBERT is an Arabic pretrained lanaguage model based on Google's BERT base architechture.


Just a small typo in architecture. You have an extra h part way through the word.

assets/docs/callmemehdi/models/AraBERT/1.md

MorganR · 2021-08-05T19:24:50Z

assets/docs/callmemehdi/models/AraBERT/1.md

+
+  3- Hidden states: Tuple of tf.Tensor (one for the output of the embeddings + one for the output of each layer) of shape (batch_size, sequence_length, hidden_size).
+
+We are interested in the last hidden output which is accessed with ``` outputs[0] ``` and has the following shape:


I'm not sure this bit is needed. A person using this model may be interested in any of the outputs.

MorganR · 2021-08-05T19:25:44Z

assets/docs/callmemehdi/models/AraBERT/1.md

+```
+(1, sequence_length, 768)
+
+With sequence_length the number of words in the input text


This explanation of sequence length is helpful. It could be included in point 1 above.

CallmeMehdi · 2021-08-05T23:23:02Z

@MorganR , I have done these changes you requested, please tell me if there is anything else you want me to change.

MorganR · 2021-08-09T12:38:57Z

Thank you for your contribution. Your pull request has been accepted according to the TensorFlow Hub Terms of Service at www.tfhub.dev/terms and Google's Privacy Policy at https://www.google.com/policies/privacy. Your model should appear on tfhub.dev within a day.

Added model file - CallmeMehdi

c3892d3

google-cla bot added the cla: no label Jul 26, 2021

MorganR suggested changes Jul 26, 2021

View reviewed changes

assets/docs/CallmeMehdi/models/AraBERT/1.md Outdated Show resolved Hide resolved

assets/docs/CallmeMehdi/models/AraBERT/1.md Outdated Show resolved Hide resolved

assets/docs/CallmeMehdi/CallmeMehdi.md Outdated Show resolved Hide resolved

Fixed license, added information about model, and fixed participant l…

fa36749

…owercase name

google-cla bot added cla: yes and removed cla: no labels Jul 27, 2021

CallmeMehdi and others added 4 commits July 28, 2021 09:05

Fixeed directory name issue

00f487b

Rename CallmeMehdi.md to callmemehdi.md

9c62795

Fixed model asset link

1432393

Fixed model path

8f431de

Fixed file by remove top-level directory

5e861bd

MorganR suggested changes Jul 28, 2021

View reviewed changes

assets/docs/callmemehdi/models/AraBERT/1.md Show resolved Hide resolved

MorganR reviewed Jul 28, 2021

View reviewed changes

assets/docs/callmemehdi/models/AraBERT/1.md Show resolved Hide resolved

CallmeMehdi added 3 commits July 28, 2021 22:39

Fixed license link

d8a9140

Added usage example of the model

3c015a4

Merge branch 'master' of https://github.com/CallmeMehdi/tfhub.dev

48a3a4e

MorganR reviewed Jul 30, 2021

View reviewed changes

Added description of output, fixed model casing, and added hub load i…

2941e8d

…n usage

MorganR suggested changes Aug 5, 2021

View reviewed changes

Fixed readme typo, and removed output[0] from readme

7c98143

MorganR approved these changes Aug 9, 2021

View reviewed changes

MorganR merged commit 8d6ee20 into tensorflow:master Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added model file - CallmeMehdi #66

Added model file - CallmeMehdi #66

CallmeMehdi commented Jul 26, 2021

google-cla bot commented Jul 26, 2021

MorganR left a comment

google-cla bot commented Jul 27, 2021

CallmeMehdi commented Jul 27, 2021

CallmeMehdi commented Jul 27, 2021

WGierke commented Jul 28, 2021

CallmeMehdi commented Jul 28, 2021

MorganR Jul 28, 2021

CallmeMehdi Jul 28, 2021

CallmeMehdi commented Jul 30, 2021

MorganR left a comment

MorganR Jul 30, 2021

CallmeMehdi Jul 30, 2021

MorganR Aug 5, 2021

MorganR Jul 30, 2021

MorganR Jul 30, 2021

CallmeMehdi commented Jul 30, 2021

MorganR left a comment

MorganR Aug 5, 2021

MorganR Aug 5, 2021

MorganR Aug 5, 2021

CallmeMehdi commented Aug 5, 2021

MorganR commented Aug 9, 2021


		## License

		[SOFTWARE LICENSE AGREEMENT - AraBERT](https://github.com/snakers4/silero-models/blob/master/LICENSE)


		```

		We need to take the last hidden state with ``` outputs[0] ``` which has the following shape:


		3- Hidden states: Tuple of tf.Tensor (one for the output of the embeddings + one for the output of each layer) of shape (batch_size, sequence_length, hidden_size).

		We are interested in the last hidden output which is accessed with ``` outputs[0] ``` and has the following shape:

Added model file - CallmeMehdi #66

Added model file - CallmeMehdi #66

Conversation

CallmeMehdi commented Jul 26, 2021

google-cla bot commented Jul 26, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

MorganR left a comment

Choose a reason for hiding this comment

google-cla bot commented Jul 27, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

CallmeMehdi commented Jul 27, 2021

CallmeMehdi commented Jul 27, 2021

WGierke commented Jul 28, 2021

CallmeMehdi commented Jul 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CallmeMehdi commented Jul 30, 2021

MorganR left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CallmeMehdi commented Jul 30, 2021

MorganR left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CallmeMehdi commented Aug 5, 2021

MorganR commented Aug 9, 2021