Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Use karma's dots reporter instead of progress for travis log #1075

Merged
merged 3 commits into from
Jun 4, 2018
Merged

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Jun 2, 2018

DEV Using dots reporter in Travis cleans up the log (see this PR's log) and makes it easier to see the failed tests. Also switch BrowserStack tests to High Sierra (10.3.x)

Also since karma 3.x, the tests run in randomized order. This caused some tests to look flaky (e.g. some local storage tests were changing a global state and not resetting it properly). I'm reverting the order of tests to a non-random behavior by adding the following to karma.conf.js

client: {
  ...,
  jasmine: {random: false}
}

We should do the same in other repos.


This change is Reviewable

Copy link
Contributor

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 It was difficult to check failed tests on Travis and this fixes it! Thank you!

@nsthorat
Copy link
Contributor

nsthorat commented Jun 4, 2018

:lgtm_strong:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@dsmilkov dsmilkov merged commit 0f81255 into master Jun 4, 2018
@dsmilkov dsmilkov deleted the log branch June 4, 2018 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants