This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Change epsilon for 32 bit float to 1e-7 and add couple more unit tests #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caisq
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Thanks for the fix!
Reviewable status: 0 of 1 approvals obtained (waiting on @caisq)
src/environment_test.ts
Outdated
| @@ -288,4 +289,8 @@ describeWithFlags('epsilon', {}, () => { | |||
| const epsilonValue = ENV.backend.floatPrecision() === 32 ? 1e-8 : 1e-4; | |||
There was a problem hiding this comment.
Seems like value in this test should also be changed or build will fail.
dsmilkov
commented
Aug 22, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @manrajgrover)
src/environment_test.ts, line 289 at r1 (raw file):
Previously, manrajgrover (Manraj Singh) wrote…
Seems like value in this test should also be changed or build will fail.
Done. Nice catch!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epsilon for 32 bit floats is changed to 1e-7 so that
tf.clip([0, 1], eps, 1-eps)returns[eps, 1-eps]instead of[0, 1].BUG
This change is