Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Move FFT ops under the spectral namespace. #1309

Merged
merged 6 commits into from
Oct 11, 2018
Merged

Move FFT ops under the spectral namespace. #1309

merged 6 commits into from
Oct 11, 2018

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Oct 11, 2018

tf.fft is now tf.spectral.fft, to match TensorFlow: https://www.tensorflow.org/api_docs/python/tf/spectral/fft

We do not support tf.fft as an alias, as this is the old way to do it in TensorFlow (the other spectral ops do not have an alias in the top-level namespace).

Note that the chain API does not change, users still call tensor.fft().


This change is Reviewable

@nsthorat nsthorat requested a review from caisq October 11, 2018 12:56
Copy link
Collaborator

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 1 approvals obtained (waiting on @caisq and @dsmilkov)

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat and @dsmilkov)


src/ops/spectral_ops.ts, line 32 at r1 (raw file):

 * const x = tf.complex(real, imag);
 *
 * x.fft().print();

add in a comment // tf.spectral.fft(x).print(); (like we do for other ops)

Copy link
Contributor Author

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 2 of 1 approvals obtained


src/ops/spectral_ops.ts, line 32 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

add in a comment // tf.spectral.fft(x).print(); (like we do for other ops)

Done

@nsthorat nsthorat merged commit e48803c into master Oct 11, 2018
@nsthorat nsthorat deleted the spectral branch October 11, 2018 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants