This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Replace vectorized packed div with channel-wise implementation to fix layers tests. #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
src/kernels/webgl/binaryop_packed_gpu.ts, line 23 at r1 (raw file):
// We do the same as in ./binaryop_gpu, with vec4 and ivec4. // TODO(https://github.com/tensorflow/tfjs/issues/1141): Understand why
can we write a unit test to catch this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tensorflow/tfjs#1140.
Added issue to track the mystery: tensorflow/tfjs#1141
This change is