This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug in the WebGL backend where we can release a texture upon reading it, regardless of whether it was sliced or not. In js code:
The fix removes all direct calls to
this.releaseTexture()
and wrapsreleaseTexture()
in a smarterthis.releaseGPUData()
which will check if there are sliced tensors depending on it before releasing.Added a unit test that reproduced the issue and is now passing.
BUG
This change is