This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Fix issue re Pooling1D layer deserialization #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of `number` versus `[number]` types for the Pooling1D layer and its subtypes, e.g., MaxPooling1D, was not done correctly, leading to errors during deserialization of such layers. This PR fixes that. Fixes: tensorflow/tfjs#331
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of
numberversus[number]types for the Pooling1D layerand its subtypes, e.g., MaxPooling1D, was not done correctly, leading to
errors during deserialization of such layers. This PR fixes that.
Fixes: tensorflow/tfjs#331
BUG: Fix the loading of Pooling1D layers such as MaxPooling1D.
This change is