This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Fix an issue in loading ndarray-style scalar serialization #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fixes two models in integration_tests/benchmarks Fixes: tensorflow/tfjs#908
dsmilkov
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
Thanks. I might have left a TODO in the benchmark file, good to double check and remove it if it's there.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov)
caisq
commented
Jan 29, 2019
There was a problem hiding this comment.
Checked. Done. Thanks for the review. I renamed the function resolveNDArrayScalarsInConfig to convertNDArrayScalarsInConfig for clarity.
Reviewable status:
complete! 1 of 1 approvals obtained
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: tensorflow/tfjs#908
This change is