fix histogram render when NaN/Infinity is present

[tafsiri]

Closes tensorflow/tfjs#999

Thanks for reporting this @caisq

---

This change is 

[caisq]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @tafsiri and @caisq)

---

src/render/histogram.ts, line 90 at r1 (raw file):

!isNaN(val) && isFinite(val

isFinite() returns false for NaN. So I think you can omit the isNaN() check here.

Also, does this merit a unit test somewhere?

[tafsiri]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @caisq)

---

src/render/histogram.ts, line 90 at r1 (raw file):

Previously, caisq (Shanqing Cai) wrote…

!isNaN(val) && isFinite(val

isFinite() returns false for NaN. So I think you can omit the isNaN() check here.

Also, does this merit a unit test somewhere?

Thanks for the suggestion. The canvas rendering makes testing this a bit tricky as there was no other error produced. Would have to rethink the testing infra a bit.