Static Code Analysis result Update #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rascani
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Thanks so much for the PR! I had just one minor comment and we'll need to fix some of the code-formatting. I can do those fix-ups if the PR has been marked to allow maintainers to edit the branch. If not, would you mind doing the fixups?
You can fix the formatting using clang-format and:
./tensorflow/lite/micro/tools/ci_build/test_code_style.sh --fix_formatting
| @@ -48,6 +48,8 @@ MicroInterpreterGraph::MicroInterpreterGraph( | |||
| resource_variables_(resource_variables) { | |||
| if (model != nullptr) { | |||
| subgraphs_ = model->subgraphs(); | |||
| } else { | |||
| subgraphs_ = nullptr; // Initialize "subgraphs_" based on the value of "model". If "model" is not null, set "subgraphs_" to point to its subgraphs. Otherwise, set it to null to avoid dereferencing a null pointer. | |||
There was a problem hiding this comment.
Can we just add a default initializer in the class declaration? Similar to what you did for MicroAllocationInfo & MicroAllocator
There was a problem hiding this comment.
I've checked tool that it also can be resolved as you suggested, I'll update the PR
rascani
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG="static code analysis result update"
Build test was done with the command below
make -f tensorflow/lite/micro/tools/make/Makefile test
There will be an additional pull request later related to static code analysis