Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

predictions-to-bigquery: Update FilterPredictionToDictFn. #219

Merged
merged 1 commit into from
Mar 1, 2023
Merged

predictions-to-bigquery: Update FilterPredictionToDictFn. #219

merged 1 commit into from
Mar 1, 2023

Conversation

cfezequiel
Copy link
Contributor

Updates process method to parse the element (PredictionLog) and extract the input tf.Example as dict and combine it with the prediction results.

Fixes #218

It's a good idea to open an issue first for discussion.

  • [ X ] Tests pass
  • [ X ] Appropriate changes to README are included in PR

@cfezequiel
predictions-to-bigquery: Update FilterPredictionToDictFn.
6d94d7c 
Updates process method to parse the element (PredictionLog)
and extract the input tf.Example as dict and combine it with the
prediction results.
@github-actions
Copy link
Contributor

Thanks for the PR! 🚀

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

@cfezequiel
Copy link
Contributor Author

@hanneshapke thanks for the approval.
@rcrowe-google @theadactyl I believe one your approvals is needed as well to merge the PR. Please have a look when you have time. I have a follow on PR that I'm planning to submit after this one.

@hanneshapke
Copy link
Contributor

/lgtm

@hanneshapke
Copy link
Contributor

@cfezequiel Do you mind updating the CODEOWNERS file?
There is a typo /tfx_addons/predictions_to_biquery, otherwise I could sign off on it.
No need for Thea's approval

@rcrowe-google rcrowe-google removed the request for review from theadactyl February 27, 2023 19:35
rcrowe-google
rcrowe-google approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks especially for adding the tests!

@rcrowe-google
Copy link
Collaborator

/lgtm
/merge

@github-actions github-actions bot merged commit d0299c9 into tensorflow:main Mar 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Merged with approvals from rcrowe-google - thanks for the contribution! 🎉

@hanneshapke
Copy link
Contributor

@cfezequiel @rcrowe-google Who is making the CODEOWNER change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanneshapke hanneshapke hanneshapke approved these changes

@rcrowe-google rcrowe-google rcrowe-google approved these changes

Assignees
No one assigned
Labels
lgtm merge-ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete implementation of FilterPredictionToDictFn in predictions-to-bigquery component.
3 participants
@cfezequiel @hanneshapke @rcrowe-google