Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable beam args to be populated from environment variables #4147

Closed
wants to merge 23 commits into from
Closed

Enable beam args to be populated from environment variables #4147

wants to merge 23 commits into from

Commits on Aug 16, 2021

  1. Added env var type and method to placeholder

    @ConverJens
    ConverJens committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    e1cd066 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Initial draft of resolving beam args from env

    @ConverJens
    ConverJens committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    708e24d View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Beam args can now be resolved from env when executen on KFP.

    @ConverJens
    ConverJens committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    e70d854 View commit details
    Browse the repository at this point in the history

  2. Moved logic to TFX Launcher to not be dependent on specific runners.

    @ConverJens
    ConverJens committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    ef40c1c View commit details
    Browse the repository at this point in the history

  3. Reverted container_entrypoint.py and container_entrypoint_test.py.

    @ConverJens
    ConverJens committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    3d3b5c9 View commit details
    Browse the repository at this point in the history

  4. Fixed failing unit tests.

    @ConverJens
    ConverJens committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    eb5d789 View commit details
    Browse the repository at this point in the history

  5. Fixed failing proto unit tests.

    @ConverJens
    ConverJens committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    a927160 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Removed debug logging. Tested and works well in KFP.

    @ConverJens
    ConverJens committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    5803f3d View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Merge branch 'master' into enable_beam_to_fetch_args_from_secrets

    @kennethyang404
    kennethyang404 authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ccff7d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Update from PR comments: Move logic from launcher to beam_executor_op… 

    …erator. Add tests and more comments.
    @ConverJens
    ConverJens committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    1f5fd95 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'enable_beam_to_fetch_args_from_secrets' of github.com:C… 

    …onverJens/tfx into enable_beam_to_fetch_args_from_secrets
    @ConverJens
    ConverJens committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    3e727ce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into enable_beam_to_fetch_args_from_secrets

    @ConverJens
    ConverJens committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    2707b8f View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Update from PR comments: Fix string handling and how to treat env var… 

    …s. Added test case.
    @ConverJens
    ConverJens committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    05420e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Fixed typo

    @ConverJens
    ConverJens committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    097a676 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Merge branch 'tensorflow:master' into enable_beam_to_fetch_args_from_… 

    …secrets
    @ConverJens
    ConverJens authored Nov 23, 2021
    Configuration menu
    Copy the full SHA
    86ad813 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Fixed linting.

    @ConverJens
    ConverJens committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    aae2b55 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tensorflow:master' into enable_beam_to_fetch_args_from_… 

    …secrets
    @ConverJens
    ConverJens authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    f9057ab View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Merge branch 'tensorflow:master' into enable_beam_to_fetch_args_from_… 

    …secrets
    @ConverJens
    ConverJens authored Dec 20, 2021
    Configuration menu
    Copy the full SHA
    4e702c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Merge branch 'tensorflow:master' into enable_beam_to_fetch_args_from_… 

    …secrets
    @ConverJens
    ConverJens authored Jan 17, 2022
    Configuration menu
    Copy the full SHA
    e2dd8a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Merge branch 'tensorflow:master' into enable_beam_to_fetch_args_from_… 

    …secrets
    @ConverJens
    ConverJens authored Feb 25, 2022
    Configuration menu
    Copy the full SHA
    f593fb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Merge branch 'master' into enable_beam_to_fetch_args_from_secrets

    @ConverJens
    ConverJens authored Mar 8, 2022
    Configuration menu
    Copy the full SHA
    5f8ebd6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge branch 'master' into enable_beam_to_fetch_args_from_secrets

    @ConverJens
    ConverJens committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    f100a4b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Merge branch 'tensorflow:master' into enable_beam_to_fetch_args_from_… 

    …secrets
    @ConverJens
    ConverJens authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    2418f38 View commit details
    Browse the repository at this point in the history