Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remotes Refactor #130

Merged
merged 6 commits into from
Oct 15, 2019
Merged

Remotes Refactor #130

merged 6 commits into from
Oct 15, 2019

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Oct 9, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

This is a long overdue refactor and general update to the remote client/server logic. Among a lot of cleanup and simplification, this update removes two unnecessary dependencies (msgpack and pyyaml), improves remote test coverage, and offers a number of performance gains.

This is a WIP.

Description

_Describe your changes in detail

Will provide when nearing a more final state.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rlizzo rlizzo added enhancement New feature or request WIP Don't merge; Work in Progress labels Oct 9, 2019
@rlizzo rlizzo self-assigned this Oct 9, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #130 into master will increase coverage by 0.25%.
The diff coverage is 94.1%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   92.37%   92.62%   +0.25%     
==========================================
  Files          61       61              
  Lines       10333    10520     +187     
  Branches     1007     1025      +18     
==========================================
+ Hits         9545     9744     +199     
+ Misses        572      564       -8     
+ Partials      216      212       -4
Impacted Files Coverage Δ
src/hangar/diagnostics/ecosystem.py 80% <ø> (ø) ⬆️
...gar/remote/request_header_validator_interceptor.py 62.22% <ø> (ø) ⬆️
tests/test_diff.py 99.69% <ø> (ø) ⬆️
tests/test_cli.py 100% <100%> (ø) ⬆️
src/hangar/remote/chunks.py 100% <100%> (ø) ⬆️
src/hangar/remote/content.py 97.85% <100%> (+0.02%) ⬆️
src/hangar/context.py 79.11% <100%> (+0.27%) ⬆️
tests/conftest.py 98.67% <100%> (+1.11%) ⬆️
tests/test_dataloaders.py 98.48% <100%> (+0.03%) ⬆️
...ar/remote/header_manipulator_client_interceptor.py 94.29% <100%> (ø) ⬆️
... and 8 more

@rlizzo
Copy link
Member Author

rlizzo commented Oct 9, 2019

Hey @hhsecond I'm brining you in on this now even though changes are still incoming. If you see anything out of place we can fix it while I work out the rest here. Do you mind giving this a review?

@rlizzo rlizzo added Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. and removed WIP Don't merge; Work in Progress labels Oct 10, 2019
@rlizzo rlizzo mentioned this pull request Oct 11, 2019
18 tasks
Copy link
Member

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like to give it another go tomorrow morning as well (to try it out locally - it's a big PR) but feel free to merge before that if you need to

src/hangar/records/commiting.py Show resolved Hide resolved
@rlizzo
Copy link
Member Author

rlizzo commented Oct 11, 2019

I'll give you some time to try it out. just let me know when you're all set. This should be merged before any other PR right now because of the changes to the test suite, but i'm not in too much of a rush.

@hhsecond
Copy link
Member

Let's merge this

@rlizzo rlizzo merged commit b399241 into tensorwerk:master Oct 15, 2019
@rlizzo rlizzo deleted the remotes-update branch November 11, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants