-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remotes Refactor #130
Remotes Refactor #130
Conversation
…dependencies and config module in favor of configparser
…removed msgpack as dependency
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 92.37% 92.62% +0.25%
==========================================
Files 61 61
Lines 10333 10520 +187
Branches 1007 1025 +18
==========================================
+ Hits 9545 9744 +199
+ Misses 572 564 -8
+ Partials 216 212 -4
|
Hey @hhsecond I'm brining you in on this now even though changes are still incoming. If you see anything out of place we can fix it while I work out the rest here. Do you mind giving this a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would like to give it another go tomorrow morning as well (to try it out locally - it's a big PR) but feel free to merge before that if you need to
I'll give you some time to try it out. just let me know when you're all set. This should be merged before any other PR right now because of the changes to the test suite, but i'm not in too much of a rush. |
Let's merge this |
Motivation and Context
Why is this change required? What problem does it solve?:
This is a long overdue refactor and general update to the remote client/server logic. Among a lot of cleanup and simplification, this update removes two unnecessary dependencies (
msgpack
andpyyaml
), improves remote test coverage, and offers a number of performance gains.This is a WIP.
Description
_Describe your changes in detail
Will provide when nearing a more final state.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist: