Dep Upgrade: fix tests and linter errors #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test helper now supports the args used by `dep_upgrade_test`, which expected to set the :deps-file and a :dry-run flag. It may be preferred to leave this as is, and instead build up the neil command as a string (rather than support neil's args in this test helper).
2 tasks
|
Hi! First of all, thanks for taking the time to look into this! I'm in front of a PC now - I'll test your changes locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neil dep upgradebabashka/neil#110I've been curious about neil and looking for more open source clojure contributions for a while - I saw this clojurians share, I thought I'd take a shot at it.
The problem is that the
:dry-runflag was being ignored when used like this:(call site in the code)
In fact,
:deps-fileis ignored here too.test-util/neilexpects all the neil args in a string as the first argument - the rest are ignored (except for:out).This PR:
test-util/neilto handle:deps-fileand:dry-runexplicitlyIt might be preferred to instead rewrite the call sites such that :dry-run is included in the first string arg:
Supporting a passed
:deps-filemay one day be useful for allowing tests to run in parallel.Feel free to merge or take whatever inspiration from this! Thanks for all the maintenance effort on these great tools!