Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bottom Navigation Bar Title Handling in TopLevelDestination #133

Merged

Conversation

teogor
Copy link
Owner

@teogor teogor commented Oct 5, 2023

This pull request addresses an issue with the handling of titles in the Bottom Navigation Bar's TopLevelDestination class. The changes include:

  • Replacing the usage of destination.iconText with destination.titleText in the Bottom Navigation Bar label to ensure consistency in the displayed text.
  • Refactoring the TopLevelDestination class to make iconText optional with a default value of titleText, and introducing a screenRoute property for improved navigation handling.

These changes enhance the readability and maintainability of the code and provide more flexibility in customizing the text displayed in the Bottom Navigation Bar.

closes #121

@teogor teogor added this to the 1.0.0-alpha03 milestone Oct 5, 2023
@teogor teogor self-assigned this Oct 5, 2023
@teogor teogor merged commit b6c73e7 into main Oct 5, 2023
4 checks passed
@zeobot zeobot bot deleted the fix/bottom-navigation-bar-title-top-level-destination-121 branch October 5, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: Enhancement: Improve Bottom Navigation Bar Title Handling in TopLevelDestination
1 participant