Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Lean to 4.11.0-rc2 #222

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Bump Lean to 4.11.0-rc2 #222

merged 1 commit into from
Aug 21, 2024

Conversation

sgouezel
Copy link
Contributor

Warning: since it changes the Lean and mathlib version, you will need to redownload the cache once you have merged this one, by doing lake exe cache get (and if this one fails, then erase your .lake folder and do lake exe cache get again).

The main change in the new Lean version is that the rule for variables inclusion has changed (see leanprover/lean4#4814). The short version is that variables that are not mentioned in the statement of a theorem are not included by default (so you need to do

include h_indep in
theorem ...

to make sure that h_indep is available in the proof), and that all typeclasses about objects in the statement are included by default (so sometimes spurious typeclasses are included, which can be avoided by reorganizing things if desired, or one can live with the spurious typeclasses). This is a big change, that increases predictability (before that, what variables were included in a theorem could depend on the proof of the theorem, so changing a proof could change the statement of the theorem, which has bitten us prety badly several times).

@teorth teorth merged commit e18765d into teorth:master Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants