Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests using a RELP server are slow #67

Closed
51-code opened this issue May 17, 2024 · 0 comments · Fixed by #71
Closed

Tests using a RELP server are slow #67

51-code opened this issue May 17, 2024 · 0 comments · Fixed by #71
Assignees
Labels
bug Something isn't working

Comments

@51-code
Copy link

51-code commented May 17, 2024

Describe the bug

Tests using a RELP server take a long time because the first connect() call to ManagedRelpConnection fails, starting a reconnect loop with a sleep time of relp.reconnectInterval. Not sure if this happens outside of the testing environment.

Very noticeable when creating multiple connections back to back.

Expected behavior

Should connect straight away to speed up tests.

How to reproduce

Run any test in EndToEndTest.java, notice that it takes just a bit longer to run than the reconnectInterval.

Screenshots

Software version

Desktop (please complete the following information if relevant):

  • OS:
  • Browser:
  • Version:

Additional context

Workaround is to set relp.reconnectInterval to a lower value in unit tests.

@51-code 51-code added the bug Something isn't working label May 17, 2024
@51-code 51-code self-assigned this May 17, 2024
kortemik pushed a commit that referenced this issue Aug 14, 2024
…uccesful connections (#71)

* Fix: solve bug where the program slept for relpConnectInterval amount of time for each successful connection

* Remove reconnectInterval setters from RebindTest

* Grammar fix in ManagedRelpConnection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant