Shade the jar, adds Main.java entrypoint #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortemik
requested changes
Apr 3, 2024
| isConnected = false; | ||
| } | ||
|
|
||
| private void sendMessage(String message, Map<String, String> headers) { |
| @@ -104,6 +118,7 @@ private FullHttpResponse processMessage() { | |||
| final Map<String, String> formattedHeaders = formatHeaders(req.headers()); | |||
| final String body = req.content().toString(UTF8_CHARSET); | |||
| if (messageHandler.onNewMessage(remoteAddress, formattedHeaders, body)) { | |||
| sendMessage(body, formattedHeaders); | |||
| @@ -162,4 +177,90 @@ private Map<String, String> formatHeaders(HttpHeaders headers) { | |||
| formattedHeaders.put("http_version", req.protocolVersion().text()); | |||
| return formattedHeaders; | |||
| } | |||
|
|
|||
| private void connect() { | |||
There was a problem hiding this comment.
this to RelpConversion too, note that copy should create a new Connection too.
kortemik
approved these changes
Apr 3, 2024
| private final static Logger LOGGER = LogManager.getLogger(MessageHandler.class); | ||
| private final RelpConnection relpConnection; |
| } | ||
|
|
||
| public boolean onNewMessage(String remoteAddress, Map<String, String> headers, String body) { | ||
| sendMessage(body, headers); |
There was a problem hiding this comment.
use
boolean rv;
try {
send
rv = true;
}
catch (Exception e) {
LOGGER.error("", e);
rv = false;
}
return rv;
| } | ||
|
|
||
| public boolean requiresToken() { | ||
| return false; |
| } | ||
|
|
||
| public boolean validatesToken(String token) { | ||
| return true; |
There was a problem hiding this comment.
make this configureable, single string.equals(token)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.