add isPromAvailable utility function #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
force-pushed
the
add-isPromAvailable-function
branch
from
9c24eb6
to
72e323d
Compare
godber
approved these changes
May 24, 2024
godber
pushed a commit
that referenced
this pull request
May 24, 2024
#3627) This is a follow-up PR to #3629 which created a utility function to test if promMetrics are available, allowing assets to be backward compatible with teraslice before promMetrics were introduced (< 1.4.0). At the same time we decided to just make `isPromAvailable()` checks everywhere promMetrics was used, instead of using a proxy to catch calls to undefined functions. See #3625 for more details. This PR makes the following changes: - Removes the `promMetricsAPI` Proxy from `terafoundation` - Add checks using `isPromAvailable` before all calls to `promMetricsAPI` functions. - Update `promMetrics docs`. - Bump teraslice from 1.7.1 to 1.7.2 - Bump job-components from 0.75.0 to 0.75.1 - Bump terafoundation from 0.64.0 to 0.64.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the isPromAvailable function to job-components that checks if promMetrics exist on context and if the API has been initialized.