-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autocomplete multiselect #157
Conversation
Thanks for your PR. |
@lumio It was limited to only a handful of symbols, and I found this package added to include way more AND handle the Windows CMD fallbacks. I wanted the multiselect to have radio buttons, which were figures you did not have in the file, as well as using arrows to help provide instructions for the multiselect. |
I don't think we should introduce dependencies for this. If you need a few more signatures we can add them to |
@terkelg this dependency is extremely small and essentially is exactly what you had for the figures. I feel like I would be literally copying from that library to include these icons here. Is it a blocker for you? |
I agree with @terkelg. Although it was meant in a good way (having the ability to use all supported characters of figures is a nice to have situation), adding a new dependency just for one or two newly used symbols sounds a little overkill to me. Would it be ok with you to extend |
Thank you. Does this look good to you @lumio? |
Sorry for the late response! If I had an item |
Also added check for title/value being a string since it doesn't seem the multiselect prompt checks for that. |
Awesome! Thanks! I will look into it tomorrow. So far it is great!
@terkelg should I merge it when I have checked it again or do you want to?
…On Thu, May 9, 2019 at 4:43 PM Majd Murad ***@***.***> wrote:
Also added check for title/value being a string since it doesn't seem the
multiselect prompt checks for that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#157 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAG7JTINREIULU2SKBTE2GLPUQ2AVANCNFSM4HGN5OKQ>
.
|
Thank you guys! Great feedback @lumio – appreciate it. |
Just so y'all know, I looked around at other prompt packages to find this feature and none of them had it. I chose to add it to yours because the code was VERY well organized and so easy to navigate compared to some of the others, so High Five right back at ya! |
Looks good to me ;) also the multiselect |
Should handle #127
Adds figures 6 figures - arrows and radio on/off
Adds paginated scrolling for long lists in multiselect
Adds radio icons for multiselect (better than blank/check IMO)
Adds autocompleteMultiselect option