Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Map, Reduce #5

Merged
merged 6 commits into from
Mar 6, 2019
Merged

implement Map, Reduce #5

merged 6 commits into from
Mar 6, 2019

Conversation

kaisugi
Copy link
Contributor

@kaisugi kaisugi commented Mar 4, 2019

implemented map and reduce function and wrote documentation about them, according to #1 .

I also added lint settings, because in #2 so many tabs were replaced with spaces (If you don't like such things, I'll just remove it).

@terkelg
Copy link
Owner

terkelg commented Mar 5, 2019

This is awesome @7ma7X! Thank you so much. Can you please remove the eslint from this PR to keep it separated? Looking forward to merging this one 👍

This reverts commit 03d4f21.
@kaisugi
Copy link
Contributor Author

kaisugi commented Mar 5, 2019

OK. Now reverted. Sorry for my meddling! 🙏

@kaisugi kaisugi changed the title implement Map, Reduce and add lint implement Map, Reduce Mar 5, 2019
@terkelg
Copy link
Owner

terkelg commented Mar 6, 2019

Thank you!

@terkelg terkelg merged commit 997f44f into terkelg:master Mar 6, 2019
@terkelg terkelg mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants