Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests to properly use tokio::test #71

Open
matko opened this issue Apr 16, 2021 · 0 comments
Open

refactor tests to properly use tokio::test #71

matko opened this issue Apr 16, 2021 · 0 comments

Comments

@matko
Copy link
Member

matko commented Apr 16, 2021

Quite a few tests that required async have been written using block_on in the past, or some other construct. This was done because I did not know about the existence of tokio::test, an attribute macro which allows one to write an async test. It would be nice if existing tests were rewritten to make use of this.

@github-actions github-actions bot added the triage issue to be triage label Apr 16, 2021
@Cheukting Cheukting added this to triage in Core dev (old) via automation Apr 26, 2021
@Cheukting Cheukting removed the triage issue to be triage label Apr 26, 2021
@Cheukting Cheukting moved this from triage to Later in Core dev (old) Apr 26, 2021
@spl spl unassigned matko Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants