Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many bugs in link2symlink extension #31

Closed
aristarh2704 opened this issue Aug 9, 2018 · 2 comments
Closed

Many bugs in link2symlink extension #31

aristarh2704 opened this issue Aug 9, 2018 · 2 comments

Comments

@aristarh2704
Copy link

aristarh2704 commented Aug 9, 2018

There are many bugs. For example,

$ mkdir a b
$ touch a/a
$ ln a/a b/b
$ rm a/a
$ rm -r a                                   
rm: cannot remove 'a/.l2s.a0001': Operation not permitted

Also a bug occurs if the target file exists.

@michalbednarski
Copy link
Collaborator

michalbednarski commented Aug 9, 2018 via email

@aristarh2704
Copy link
Author

I think using a separate folder for all l2s files is the best solution, for example, /.l2s/ in guest root
It's need make this folder inaccessible for reading and writing
But the second bug is due to the fact that l2s does not check the existence of the target file

@aristarh2704 aristarh2704 reopened this Aug 10, 2018
michalbednarski added a commit to michalbednarski/termux-packages that referenced this issue Aug 28, 2018
* Fixes running on broken Huawei devices (termux/proot#15)
* Mapping of uids coming from getsockopt(SO_PEERCRED) (termux/proot#36)
* Fixed results of `strace` after SIGSYS was suppressed
* Don't fail on removing broken link2symlink (termux/proot#31)
fornwall pushed a commit to termux/termux-packages that referenced this issue Aug 28, 2018
* Fixes running on broken Huawei devices (termux/proot#15)
* Mapping of uids coming from getsockopt(SO_PEERCRED) (termux/proot#36)
* Fixed results of `strace` after SIGSYS was suppressed
* Don't fail on removing broken link2symlink (termux/proot#31)
Grimler91 pushed a commit that referenced this issue Jul 25, 2022
Also allow specifying alternative directory
for link2symlink targets by providing absolute host path
in PROOT_L2S_DIR

Fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants