-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many bugs in link2symlink extension #31
Comments
It's normal that if you remove link target that link becomes broken. When
proot creates first link2symlink to file it puts two files with name
starting with ".l2s." in directory where original file was (and which was
deleted in your example).
I see two possible solutions for that:
* Hiding ".l2s." files (so `rm -rf` won't be able to remove folder with
them), however I don't really like that solution as it means that you won't
be able to delete folder which had hardlinked files and renaming folder
would still break links.
* Allowing user to specify folder which will contain all "l2s" files (this
would require user to specify folder in order to get fix (and i wouldn't
want to specify default one as it would mean leaving leftovers after user
deletes whole chroot))
|
I think using a separate folder for all l2s files is the best solution, for example, /.l2s/ in guest root |
michalbednarski
added a commit
to michalbednarski/termux-packages
that referenced
this issue
Aug 28, 2018
* Fixes running on broken Huawei devices (termux/proot#15) * Mapping of uids coming from getsockopt(SO_PEERCRED) (termux/proot#36) * Fixed results of `strace` after SIGSYS was suppressed * Don't fail on removing broken link2symlink (termux/proot#31)
fornwall
pushed a commit
to termux/termux-packages
that referenced
this issue
Aug 28, 2018
* Fixes running on broken Huawei devices (termux/proot#15) * Mapping of uids coming from getsockopt(SO_PEERCRED) (termux/proot#36) * Fixed results of `strace` after SIGSYS was suppressed * Don't fail on removing broken link2symlink (termux/proot#31)
Grimler91
pushed a commit
that referenced
this issue
Jul 25, 2022
Also allow specifying alternative directory for link2symlink targets by providing absolute host path in PROOT_L2S_DIR Fixes #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are many bugs. For example,
$ mkdir a b $ touch a/a $ ln a/a b/b $ rm a/a $ rm -r a rm: cannot remove 'a/.l2s.a0001': Operation not permitted
Also a bug occurs if the target file exists.
The text was updated successfully, but these errors were encountered: